refactor: Rename the surface transform -> localToGlobalTransform#4958
Merged
paulgessinger merged 6 commits intoacts-project:mainfrom Jan 15, 2026
Merged
refactor: Rename the surface transform -> localToGlobalTransform#4958paulgessinger merged 6 commits intoacts-project:mainfrom
paulgessinger merged 6 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
junggjo9
commented
Jan 13, 2026
Contributor
andiwand
reviewed
Jan 14, 2026
andiwand
previously approved these changes
Jan 14, 2026
Member
|
Do we really want to overload |
junggjo9
commented
Jan 14, 2026
andiwand
previously approved these changes
Jan 14, 2026
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
junggjo9
force-pushed
the
transformToLocalToGlobal
branch
from
c95a8c3 to
9147983
Compare
acts-policybot
bot
dismissed
andiwand’s stale review
Invalidated by push of 9147983
|
paulgessinger
changed the title
Collaborator
acts-project-service
added
the
Breaks Athena build
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 23, 2026
…s-project#4958) - Rename all occurances of the surface transform -> localToGlobalTransform - Introduce localToGlobalTransform method in the IDetectorElement - Mark the transform() methods as deprecated
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 23, 2026
…e localToGlobalTransform in the child classes (acts-project#4970) - localToGlobalTransform is the primary interface method since acts-project#4958 - Introduce a isSensitive() method to the DetectorElementBase & the Surface
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 24, 2026
…s-project#4958) - Rename all occurances of the surface transform -> localToGlobalTransform - Introduce localToGlobalTransform method in the IDetectorElement - Mark the transform() methods as deprecated
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 24, 2026
…e localToGlobalTransform in the child classes (acts-project#4970) - localToGlobalTransform is the primary interface method since acts-project#4958 - Introduce a isSensitive() method to the DetectorElementBase & the Surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- END COMMIT MESSAGE ---
Towards #4467
Tagging: @paulgessinger, @asalzburger, @andiwand, @AJPfleger, @dimitra97