fix: bin number underflow in HoughVertexFinder#5060
Merged
andiwand merged 3 commits intoacts-project:mainfrom Feb 8, 2026
Merged
fix: bin number underflow in HoughVertexFinder#5060andiwand merged 3 commits intoacts-project:mainfrom
andiwand merged 3 commits intoacts-project:mainfrom
Conversation
Contributor
andiwand
approved these changes
Feb 6, 2026
|
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 23, 2026
fix bin nr underflow
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 24, 2026
fix bin nr underflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bin nr underflow
--- END COMMIT MESSAGE ---
When filling the Hough image space, we ensured that the initial bin is not negative and final bin is not beyond the axis range. Unfortunately, possibility of the opposite was overlooked. The checks that used to use
sp.r()might not be precise enough, and we could end up with negative final bin, which would be transformed into something large bystatic_cast<std::uint32_t>().Now, the checks use proper radius. Furthermore, extra check to ensure we don't have negative number in
static_cast<std::uint32_t>()was added.As a bonus, spacepoint class does not need
.r()method any more.