chore!: remove legacy material mapping#5236
Merged
asalzburger merged 14 commits intoacts-project:mainfrom Mar 24, 2026
Merged
Conversation
github-actions
bot
added
Component - Core
Contributor
asalzburger
force-pushed
the
chore-remove-legacy-material-mapping
branch
from
c296cad to
91e95f3
Compare
asalzburger
force-pushed
the
chore-remove-legacy-material-mapping
branch
from
e0feaf9 to
9e662d5
Compare
|
noemina
approved these changes
Mar 24, 2026
Contributor
noemina
left a comment
noemina
left a comment
There was a problem hiding this comment.
A nice clean-up! Thanks
It seems reasonable to me.
Contributor
Author
|
Oh - this was of course breaking, not sure if we need to unroll this ? @andiwand |
Member
|
I think we should if it's breaking |
Contributor
|
yes I fear we have to revert this and wait for the next major release. in the meantime we can already deprecate this API and remove the code from Athena |
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
Mar 25, 2026
We are supporting still two type of material mapping approaches: a - one using the propagator / navigator b - a robust one using only line intersections This PR removes the first option and only keeps the second, for the moment volume mapping is (for a short time) not supported, it will be integrated into b. ## What changed ### Removed legacy algorithm path - Deleted Examples/Algorithms/MaterialMapping/include/ActsExamples/MaterialMapping/CoreMaterialMapping.hpp - Deleted Examples/Algorithms/MaterialMapping/src/CoreMaterialMapping.cpp - Replaced legacy MaterialMapping implementation with former core-based implementation: - Updated Examples/Algorithms/MaterialMapping/include/ActsExamples/MaterialMapping/MaterialMapping.hpp - Updated Examples/Algorithms/MaterialMapping/src/MaterialMapping.cpp ### MaterialMapping now uses Acts::MaterialMapper and outputs mapped/unmapped tracks. ### Removed old core mapper infrastructure from Core/Material: - Deleted Core/include/Acts/Material/SurfaceMaterialMapper.hpp - Deleted Core/include/Acts/Material/VolumeMaterialMapper.hpp - Deleted Core/src/Material/SurfaceMaterialMapper.cpp - Deleted Core/src/Material/VolumeMaterialMapper.cpp ### Removed associated unit tests: - Deleted Tests/UnitTests/Core/Material/SurfaceMaterialMapperTests.cpp - Deleted Tests/UnitTests/Core/Material/VolumeMaterialMapperTests.cpp ### Updated build wiring: - Examples/Algorithms/MaterialMapping/CMakeLists.txt - Core/src/Material/CMakeLists.txt - Tests/UnitTests/Core/Material/CMakeLists.txt --- END COMMIT MESSAGE --- With a simple sequence of 3 commands one can now re-create the ODD material maps: ```sh python material_recording.py -n1000 -t1000 -o odd_material_geant4 python material_mapping.py -n 1000000 -i odd_material_geant4.root -o odd_material python material_validation.py -n 1000 -t 1000 -m odd_material_map.root -o odd_material_validated -p ``` Output is as follows: <img width="793" height="631" alt="overlay_profile_ratio_v_eta_t_X0" src="https://github.com/user-attachments/assets/976b6005-0c57-416e-9ad1-26c1e919fcda" /> Any further description goes here, @-mentions are ok here! - Use a *conventional commits* prefix: [quick summary](https://www.conventionalcommits.org/en/v1.0.0/#summary) - We mostly use `feat`, `fix`, `refactor`, `docs`, `chore` and `build` types. - A milestone will be assigned by one of the maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are supporting still two type of material mapping approaches:
a - one using the propagator / navigator
b - a robust one using only line intersections
This PR removes the first option and only keeps the second, for the moment volume mapping is (for a short time) not supported, it will be integrated into b.
What changed
Removed legacy algorithm path
MaterialMapping now uses Acts::MaterialMapper and outputs mapped/unmapped tracks.
Removed old core mapper infrastructure from Core/Material:
Removed associated unit tests:
Updated build wiring:
--- END COMMIT MESSAGE ---
With a simple sequence of 3 commands one can now re-create the ODD material maps:
Output is as follows:
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.