refactor!: Generalize navigation options for external surfaces#5243
Merged
kodiakhq[bot] merged 5 commits intoacts-project:mainfrom Mar 23, 2026
Merged
Conversation
junggjo9
reviewed
Mar 17, 2026
Co-authored-by: junggjo9 <junggjo90@gmail.com>
Contributor
|
paulgessinger
approved these changes
Mar 23, 2026
benjaminhuth
pushed a commit
to benjaminhuth/acts
that referenced
this pull request
Mar 23, 2026
…project#5243) Generalizes external surfaces from `Navigator::Options` to `NavigatorPlainOptions` which is the base for all our navigators. This way all navigators fulfill the interface necessary to deal with external surfaces. The `DirectNavigator` now also uses this central external surface list. Also - adapt `Navigator` to handle the new option vs the previous 2 lists - rename `Navigator::State::reset` to `resetForRenavigation` - rename `insertExternalSurface` to `appendExternalSurface` to hit that order is important - improve `appendExternalSurface` doc - downstream changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes external surfaces from
Navigator::OptionstoNavigatorPlainOptionswhich is the base for all our navigators. This way all navigators fulfill the interface necessary to deal with external surfaces. TheDirectNavigatornow also uses this central external surface list.Also
Navigatorto handle the new option vs the previous 2 listsNavigator::State::resettoresetForRenavigationinsertExternalSurfacetoappendExternalSurfaceto hit that order is importantappendExternalSurfacedoc--- END COMMIT MESSAGE ---