Skip to content

refactor: Pass geo context to SurfaceArray lookup and return std::span#5291

Merged
andiwand merged 6 commits intoacts-project:mainfrom
andiwand:refactor-surfacearray-gctx-and-span
Mar 30, 2026
Merged

refactor: Pass geo context to SurfaceArray lookup and return std::span#5291
andiwand merged 6 commits intoacts-project:mainfrom
andiwand:refactor-surfacearray-gctx-and-span

Conversation

@andiwand
Copy link
Copy Markdown
Contributor

  • Pass the geometry context over using a default constructed one
  • Return a std:span to surface pointers over a reference to a std::vector

--- END COMMIT MESSAGE ---

@andiwand andiwand added this to the next milestone Mar 26, 2026
@github-actions github-actions bot added the Component - Core Affects the Core module label Mar 26, 2026
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

📊: Physics performance monitoring for 60a7a24

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review March 30, 2026 09:48
Copy link
Copy Markdown
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sonarqubecloud
Copy link
Copy Markdown

@andiwand andiwand merged commit e6de2f8 into acts-project:main Mar 30, 2026
47 of 64 checks passed
@andiwand andiwand deleted the refactor-surfacearray-gctx-and-span branch March 30, 2026 19:42
@andiwand andiwand modified the milestones: next, v46.1.0 Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Component - Plugins Affects one or more Plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants