fix(cmake): add Alignment component before Plugins subdirectory#5329
Merged
paulgessinger merged 1 commit intoacts-project:mainfrom Apr 10, 2026
Merged
fix(cmake): add Alignment component before Plugins subdirectory#5329paulgessinger merged 1 commit intoacts-project:mainfrom
paulgessinger merged 1 commit intoacts-project:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Reorders top-level CMake component inclusion so the Alignment component is defined before the Plugins subdirectory, ensuring plugins (notably PluginMille) can link against Acts::Alignment/ActsAlignment during package component loading in downstream builds.
Changes:
- Move
add_component_if(Alignment ...)beforeadd_subdirectory(Plugins)to satisfy plugin dependency ordering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Member
andiwand
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cmake): add Alignment component before Plugins subdirectory
--- END COMMIT MESSAGE ---
With the addition of the Mille plugin, which depends on the Alignment component, there is a new ordering requirement on how the targets are defined. This is in particular relevant in third party project (possibly why it was not noticed here) where without this fix we get:
which is caused because at the time PluginMille tries to check its dependencies, the Alignment component is not loaded yet.
With the change here, there are no errors loading Acts with the Mille plugin.
There are no Plugin dependencies in the Alignment component, so we are not introducing the reverse issue here.