chore: Remove templated version of HoughVertexFinder#5341
Open
pbalek wants to merge 1 commit intoacts-project:mainfrom
Open
chore: Remove templated version of HoughVertexFinder#5341pbalek wants to merge 1 commit intoacts-project:mainfrom
pbalek wants to merge 1 commit intoacts-project:mainfrom
Conversation
Contributor
Contributor
|
thanks for handling this @pbalek ! I would delay merging this until we are ready to cut the next major release |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove templated HoughVertexFinder
--- END COMMIT MESSAGE ---
This PR removes the original version of
HoughVertexFinderthat used a template for spacepoints type. Also removes respective unit tests.The new version
HoughVertexFinder2usingSpacePointContainer2is available since #5108 and remains unchanged. The is alsoHoughVertexFinderAlgorithmthat already uses this new version.