Skip to content

fix: dump_args_calls#5343

Open
timadye wants to merge 2 commits intoacts-project:mainfrom
timadye:adye-py4
Open

fix: dump_args_calls#5343
timadye wants to merge 2 commits intoacts-project:mainfrom
timadye:adye-py4

Conversation

@timadye
Copy link
Copy Markdown
Contributor

@timadye timadye commented Apr 13, 2026

  1. dump_args_calls was broken for recent namespace changes.
  2. Improve it to work for subsequent imports, by hooking the import statement. Note, this is only done if the user calls acts.examples.dump_args_calls() for debugging.
  3. Led to full_chain_test.py fixes:
    a. addDigiParticleSelection needs to specify measurements, not hits.
    b. Use --random-seed value, rather than hard-coding it.

@github-actions github-actions bot added this to the next milestone Apr 13, 2026
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

📊: Physics performance monitoring for d4783ad

Full contents

physmon summary

@sonarqubecloud
Copy link
Copy Markdown

@AJPfleger AJPfleger self-requested a review April 14, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Examples Affects the Examples module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant