Skip to content

Conversation

@baschlag
Copy link
Contributor

Adds a unit test for user-defined track types for the AMVF and fixed one bug that appeared while testing it.

@baschlag baschlag added the Improvement Changes to an existing feature label Mar 30, 2020
@acts-issue-bot acts-issue-bot bot removed the Triage label Mar 30, 2020
@baschlag baschlag added this to the 0.21.00 milestone Mar 30, 2020
@baschlag baschlag changed the title Vertexing: Add AMVF unit test for user-defined track type Add AMVF unit test for user-defined track type Mar 30, 2020
@baschlag baschlag requested review from a team and robertlangenberg March 31, 2020 07:19
@robertlangenberg robertlangenberg removed request for a team and robertlangenberg March 31, 2020 07:20
@baschlag baschlag requested review from a team and robertlangenberg March 31, 2020 07:22
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #75 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   42.55%   42.61%   +0.05%     
==========================================
  Files         348      348              
  Lines       16637    16584      -53     
  Branches     7907     7880      -27     
==========================================
- Hits         7080     7067      -13     
+ Misses       4893     4875      -18     
+ Partials     4664     4642      -22
Impacted Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 33.09% <0%> (+1.76%) ⬆️
Core/include/Acts/Surfaces/Surface.hpp 50% <0%> (-10%) ⬇️
Core/src/Surfaces/StrawSurface.cpp 34.78% <0%> (-3.22%) ⬇️
Core/src/Surfaces/PerigeeSurface.cpp 38.09% <0%> (-3.21%) ⬇️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp 81.25% <0%> (-2.09%) ⬇️
Core/src/Surfaces/CylinderBounds.cpp 57.77% <0%> (-1.8%) ⬇️
Core/src/Surfaces/RadialBounds.cpp 76% <0%> (-1.78%) ⬇️
Core/src/Surfaces/PlaneSurface.cpp 43.05% <0%> (-1.69%) ⬇️
Core/src/Surfaces/RectangleBounds.cpp 35.29% <0%> (-1.55%) ⬇️
Core/src/Surfaces/Surface.cpp 47.76% <0%> (-1.5%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a6f84...151ee38. Read the comment docs.

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@asalzburger
Copy link
Contributor

Mergin this in, overall unit test coverage increases.

@asalzburger asalzburger merged commit 4814b8e into acts-project:master Mar 31, 2020
Copy link
Contributor

@robertlangenberg robertlangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@baschlag baschlag deleted the add_amvf_user_tracktype_test branch May 19, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Changes to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants