chore: Add a meta.name to the eslint plugin.

[connorshea]

Noticed this'll break when you upgrade oxlint if this isn't done (noticed with https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629/job/58631736649), so figured I'd contribute that :)

Also fix the config for the glob patterns in the no-restricted-imports rule. Noticed this by running yarn oxlint --report-unused-disable-directives-severity=error and taking a look at the directives that were unnecessarily-disabled. oxlint uses rust fast-glob for glob matching generally, and so the * character matches everything except / separators. And so you'd be missing files nested under directories with the previous glob.

Summary by CodeRabbit

• Chores
  • Enhanced the ESLint plugin configuration by adding name metadata, improving plugin identification and proper integration with ESLint tooling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	45755fc
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget/deploys/69478a46dda00f00083d49fd
😎 Deploy Preview	https://deploy-preview-6463.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify]

✅ Deploy Preview for actualbudget-website canceled.

Name	Link
🔨 Latest commit	45755fc
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget-website/deploys/69478a46561fc4000832e654

[coderabbitai]

Walkthrough

Adds a meta field with plugin name to the CommonJS export of the ESLint plugin, creates a release-notes file documenting the change, and broadens import-matching patterns in .oxlintrc.json to apply recursively to several directories.

Changes

Cohort / File(s)	Change Summary
ESLint plugin export packages/eslint-plugin-actual/lib/index.js	Added a meta object to module.exports with { name: 'eslint-plugin-actual' }, augmenting the exported API surface.
Configuration .oxlintrc.json	Expanded import restriction patterns from single-level globs (*.api, *.web, *.electron, @actual-app/web/*) to recursive globs (**/*.api, **/*.web, **/*.electron, @actual-app/web/**/*).
Release notes upcoming-release-notes/6463.md	New release note documenting the addition of the plugin name metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas to focus on:

• packages/eslint-plugin-actual/lib/index.js — verify plugin export shape and any consumers expecting prior shape.
• .oxlintrc.json — confirm the expanded globs match intended paths and do not introduce unintended restrictions.
• upcoming-release-notes/6463.md — factual accuracy of the note.

Poem

🐰
A little rabbit hops to say,
I named the plugin — hip hooray!
Globs stretch farther through the glen,
Notes record the change for when —
Code hops on, and smiles remain.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: Add a meta.name to the eslint plugin.' directly and accurately describes the main change: adding a meta.name property to the ESLint plugin module exports.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/eslint-plugin-actual/lib/index.js (1)

2-4: Consider reading meta.name from package.json instead of hardcoding it.

While the hardcoded value 'eslint-plugin-actual' correctly matches your package name and follows ESLint naming conventions, the recommended approach is to read name and version from package.json dynamically. This keeps metadata synchronized with your package definition and prevents duplication.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1fe1bad and b95e396.

📒 Files selected for processing (2)

• packages/eslint-plugin-actual/lib/index.js (1 hunks)
• upcoming-release-notes/6463.md (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx}: Use TypeScript for all code
Use descriptive variable names with auxiliary verbs (e.g., 'isLoaded', 'hasError')
Use named exports for components and utilities; avoid default exports except in specific cases
Use functional and declarative programming patterns - avoid classes
Use the 'function' keyword for pure functions
Structure files with: exported component/page, helpers, static content, types
Organize imports in the following order: React imports, built-in Node.js modules, external packages, Actual packages, parent imports, sibling imports, index imports, with newlines between groups
Never use 'console.*' - use logger instead (enforced by ESLint rule 'actual/prefer-logger-over-console')
Never import from 'uuid' without destructuring - use 'import { v4 as uuidv4 } from 'uuid''

Files:

• packages/eslint-plugin-actual/lib/index.js

🧠 Learnings (6)

📚 Learning: 2025-09-30T00:28:46.031Z

Learnt from: lelemm
Repo: actualbudget/actual PR: 5786
File: packages/plugins-core/src/types/actualPluginManifest.ts:10-10
Timestamp: 2025-09-30T00:28:46.031Z
Learning: The `ActualPluginManifest` interface in packages/plugins-core/src/types/actualPluginManifest.ts must be used with DOM contexts and requires the `plugin?: Blob` field to remain as Blob type.

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

📚 Learning: 2025-12-20T22:55:54.021Z

Learnt from: matt-fidd
Repo: actualbudget/actual PR: 6462
File: .oxlintrc.json:22-27
Timestamp: 2025-12-20T22:55:54.021Z
Learning: The `actual/prefer-logger-over-console` ESLint rule in packages/eslint-plugin-actual only enforces logger usage in files within `packages/loot-core/src/server` directory. Files outside this path are not checked by this rule, even when the rule is enabled globally in .oxlintrc.json.

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

📚 Learning: 2024-11-26T13:07:02.794Z

Learnt from: lelemm
Repo: actualbudget/actual PR: 3891
File: packages/loot-core/src/shared/rules.ts:209-212
Timestamp: 2024-11-26T13:07:02.794Z
Learning: The file `packages/loot-core/src/shared/rules.ts` is not yet translated, so internationalization using the `t()` function is not required here.

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

📚 Learning: 2025-11-25T22:34:13.068Z

Learnt from: MatissJanis
Repo: actualbudget/actual PR: 6158
File: packages/desktop-client/src/components/mobile/schedules/MobileSchedulesPage.tsx:124-124
Timestamp: 2025-11-25T22:34:13.068Z
Learning: The ESLint rule `actual/prefer-logger-over-console` (which requires using logger instead of console.* methods) only applies to the packages/api package. In other packages like desktop-client and sync-server, using console methods (console.error, console.log, etc.) is acceptable.

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

📚 Learning: 2025-10-12T04:00:51.978Z

Learnt from: lelemm
Repo: actualbudget/actual PR: 5786
File: packages/plugins-core/vite.config.mts:27-35
Timestamp: 2025-10-12T04:00:51.978Z
Learning: In the Actual Budget plugins architecture, the actual-app/plugins-core package is designed to be self-contained. Plugin authors should only need to install actual-app/plugins-core, which bundles the internal monorepo packages (actual-app/shared-types, actual-app/query, actual-app/components) at build time. Only common dependencies like React, React-DOM, and i18next are kept as peerDependencies/externals to avoid duplication with the host application.

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Never use 'console.*' - use logger instead (enforced by ESLint rule 'actual/prefer-logger-over-console')

Applied to files:

• packages/eslint-plugin-actual/lib/index.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: web
• GitHub Check: validate-cli
• GitHub Check: test
• GitHub Check: Analyze

🔇 Additional comments (1)

upcoming-release-notes/6463.md (1)

1-6: LGTM!

The release notes accurately describe the maintenance change and follow the expected format.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b95e396 and 45755fc.

📒 Files selected for processing (1)

• .oxlintrc.json (2 hunks)

🧰 Additional context used

🧠 Learnings (9)

📓 Common learnings

Learnt from: matt-fidd
Repo: actualbudget/actual PR: 5936
File: packages/desktop-electron/package.json:95-102
Timestamp: 2025-10-16T14:46:14.026Z
Learning: In the actualbudget/actual repository, PR #5936 (Electron bump to 38.3.0 and electron/notarize to 3.1.0) is coordinated with PR #5937, which handles the Node.js version migration (dropping Node 20 support, requiring Node 22+ for Electron compatibility).

📚 Learning: 2025-10-12T04:07:06.002Z

Learnt from: lelemm
Repo: actualbudget/actual PR: 5786
File: packages/api/tsconfig.dist.json:14-14
Timestamp: 2025-10-12T04:07:06.002Z
Learning: In the Actual Budget codebase, when rootDir is removed from packages/loot-core/tsconfig.api.json to allow referencing files outside the loot-core directory, the declaration output structure changes. The path alias for loot-core in packages/api/tsconfig.dist.json must be updated from "./types/loot-core/src/*" to "./types/loot-core/loot-core/src/*" to match the new emitted declaration paths, as TypeScript preserves the full directory structure from the project root when rootDir is not specified.

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to packages/loot-core/src/**/*.{ts,tsx,js,jsx} : Don't directly reference platform-specific imports (.api, .web, .electron) - use conditional exports in loot-core for platform-specific code

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Organize imports in the following order: React imports, built-in Node.js modules, external packages, Actual packages, parent imports, sibling imports, index imports, with newlines between groups

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to packages/loot-core/src/**/*.{ts,tsx,js,jsx} : Never import 'actual-app/web/*' in 'loot-core' package

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-20T22:55:54.021Z

Learnt from: matt-fidd
Repo: actualbudget/actual PR: 6462
File: .oxlintrc.json:22-27
Timestamp: 2025-12-20T22:55:54.021Z
Learning: The `actual/prefer-logger-over-console` ESLint rule in packages/eslint-plugin-actual only enforces logger usage in files within `packages/loot-core/src/server` directory. Files outside this path are not checked by this rule, even when the rule is enabled globally in .oxlintrc.json.

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to **/*.{tsx,jsx} : Don't use 'React.*' patterns - use named imports instead

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to **/*.{ts,tsx} : Use inline type imports: 'import { type MyType } from '...''

Applied to files:

• .oxlintrc.json

📚 Learning: 2025-12-04T19:58:16.062Z

Learnt from: CR
Repo: actualbudget/actual PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T19:58:16.062Z
Learning: Applies to **/*.{tsx,jsx} : Never import colors directly - use theme instead

Applied to files:

• .oxlintrc.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: validate-cli
• GitHub Check: test
• GitHub Check: web
• GitHub Check: Analyze

🔇 Additional comments (1)

.oxlintrc.json (1)

317-317: Pattern change correctly broadens platform-specific import restriction scope.

The change from *.api/*.web/*.electron to **/*.api/**/*.web/**/*.electron appropriately expands the eslint/no-restricted-imports rule to match platform-specific imports at any directory depth, not just the root level. This aligns with the guideline against directly referencing platform-specific imports—the codebase should use conditional exports instead. No existing violations were found.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for @actual-app/web imports in loot-core
echo "=== Checking for @actual-app/web imports in loot-core ==="
rg -n "from ['\"]@actual-app/web" packages/loot-core/ --type-add 'source:*.{ts,tsx,js,jsx}' --type source 2>/dev/null || echo "No matches found"

# Also check the pattern syntax in .oxlintrc.json to confirm it exists and is valid
echo -e "\n=== Verifying .oxlintrc.json content around line 331 ==="
sed -n '325,340p' .oxlintrc.json

Repository: actualbudget/actual

Length of output: 774

---

Fix the architectural boundary violation: @actual-app/web import in loot-core

The expanded pattern correctly catches a violation at packages/loot-core/src/platform/client/undo/index.ts:3, where @actual-app/web/src/modals/modalsSlice is imported into loot-core. This violates the architectural boundary preventing loot-core from importing web code. The import must be removed or refactored to use conditional exports in loot-core instead.

🤖 Prompt for AI Agents

.oxlintrc.json around line 331: the glob pattern is catching an architectural
boundary violation where loot-core imports @actual-app/web
(packages/loot-core/src/platform/client/undo/index.ts:3). Remove the direct
import from loot-core and instead refactor by either (a) moving the shared
functionality into a common package that both web and loot-core can depend on,
or (b) exposing a conditional export or abstraction API from loot-core that web
can implement/use so loot-core does not import web code; update the offending
file to use the refactored API or the common package, and verify the linter no
longer reports the violation.

[MatissJanis]

Thanks!