Skip to content

updating idna to 0.5.2#1141

Merged
anonrig merged 2 commits into
mainfrom
lemire/idna051
May 12, 2026
Merged

updating idna to 0.5.2#1141
anonrig merged 2 commits into
mainfrom
lemire/idna051

Conversation

@lemire
Copy link
Copy Markdown
Member

@lemire lemire commented May 11, 2026

Self-describing.

@anonrig
Copy link
Copy Markdown
Member

anonrig commented May 12, 2026

Tests are failing

@lemire
Copy link
Copy Markdown
Member Author

lemire commented May 12, 2026

@anonrig Someone used AI and it injected non-ASCII chars.

Easy fix.

@lemire
Copy link
Copy Markdown
Member Author

lemire commented May 12, 2026

Problem is with idna, upstream ada-url/idna#76

AI wants to assume UTF-8 but we want to support cases where people do not default on UTF-8 (common under Windows).

@lemire
Copy link
Copy Markdown
Member Author

lemire commented May 12, 2026

Hopefully, it will pass now.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (c9adf5e) to head (8abf92d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ada_idna.cpp 20.83% 8 Missing and 11 partials ⚠️

❌ Your patch check has failed because the patch coverage (20.83%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   60.34%   60.21%   -0.13%     
==========================================
  Files          37       37              
  Lines        6057     6068      +11     
  Branches     2954     2959       +5     
==========================================
- Hits         3655     3654       -1     
- Misses        574      580       +6     
- Partials     1828     1834       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lemire
Copy link
Copy Markdown
Member Author

lemire commented May 12, 2026

@anonrig This is good now.

@lemire lemire changed the title updating idna to 0.5.1 updating idna to 0.5.2 May 12, 2026
@anonrig anonrig merged commit de1bb25 into main May 12, 2026
53 of 55 checks passed
@anonrig anonrig deleted the lemire/idna051 branch May 12, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants