modified get_pulses to reduce errors #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 81 pulses - adjust lockout for dht11
tannewt
requested changes
Apr 16, 2018
|
@mrmcwethy @tannewt Any concerns with this? |
|
@jerryneedell I looked at what you did and I agree with it. Nice job. |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 30, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.1.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#10 from jerryneedell/jerryn_negative > Merge pull request adafruit/Adafruit_CircuitPython_DHT#8 from jerryneedell/jerryn_dht > Merge pull request adafruit/Adafruit_CircuitPython_DHT#6 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_DHT#5 from sommersoft/new_docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were often errors associated with prematurely cutting off the pulse train. Rather than depend on the exact number of incoming pulses, which varies depending on the timing of the start up, what for a timeout interval than always use the last 81 pulses received. This reduces the number of errors , especially on the faster M4 boards.
Also added a test to see if this was a dht11 and increased the delay between reads to 1 second as in the data sheet. dht22 uses .5 seconds