Update to fill/outline color check#11
Merged
makermelissa merged 2 commits intoadafruit:masterfrom Aug 13, 2019
Merged
Conversation
The current code doesn't draw the button if both fill and outline are 0x000000 (black). With the proposed change, if either the outline or the fill have been assigned any value, the check will pass. If fill and outline are both None, nothing will be drawn.
makermelissa
requested changes
Aug 13, 2019
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Just an extra space, otherwise it looks good.
Removed extra spaces on line 114
makermelissa
approved these changes
Aug 13, 2019
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 14, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#12 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#6 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#5 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#11 from jpecor/patch-1 > Fixed typo in rtd path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code doesn't draw the button if both fill and outline are 0x000000 (black). With the proposed change, if either the outline or the fill have been assigned any value, the check will pass. If fill and outline are both None, nothing will be drawn.