Skip to content

Conversation

@jimbobbennett
Copy link

Created a Circuitpython version of Parse by lifting the Python lib code and tweaking till it ran. Would be great to have this in the community bundle.

@tannewt
Copy link
Member

tannewt commented Apr 3, 2020

Hi @jimbobbennett I believe you'll want to preserve the Python license in your repo: https://github.com/python/cpython/blob/master/LICENSE instead of having it designated MIT.

What did you have to tweak to make it run?

@jimbobbennett
Copy link
Author

@tannewt - what is the correct thing to do here (I'm not up on license rules). Should I just copy the license from the Python repo and use that? I notice MicroPython has done the same as me and used the MIT license.

For the tweaks - there wasn't much. I removed deprecated methods to make it smaller (as raw source it was blowing the memory on my PyBadge), then had to deal with some unsupported features in CircuitPython:

  • str.isascii isn't available in CircuitPython

  • There was a regex in there that contains features CircuitPython doesn't support:

    _asciire = re.compile(r'([\x00-\x7f]+)')

@tannewt
Copy link
Member

tannewt commented Apr 6, 2020

Thanks for documenting the differences! I would just copy the same license over.

Did micropython do it in micropython-lib or micropython proper? I don't think making it MIT is proper though your changes could be licensed that way.

@jimbobbennett
Copy link
Author

It was from micropython-lib.

I've updated the license to the Python one.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great! Thank you!

@tannewt tannewt merged commit 2fab952 into adafruit:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants