Add maker feather aiot s3#1108
Merged
makermelissa merged 6 commits intoDec 1, 2022
Merged
Conversation
makermelissa
requested changes
Nov 28, 2022
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Hi, thanks for adding. It looks like it's not passing the checks because you have some non-standard features:
AI and IoT. We generally try and keep the features narrowed down to a list that several boards share.
Contributor
Author
|
Hi, sorry for the inconveniences, I have made changes on the errors. Please me to add the board again. Thanks |
makermelissa
approved these changes
Dec 1, 2022
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Thanks, looks good.
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am from Cytron technologies. Please help to add this new board - Maker Feather AIoT S3
Thanks.