Initial CircuitPython Installer Coding#1137
Merged
Merged
Conversation
tannewt
previously approved these changes
Jan 31, 2023
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Happy to have this available for testing. One weirdness is the three files named cpinstaller.js, installer.js and wsinstaller.js. Could they be renamed to be clearer?
Collaborator
Author
|
Oh, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to put this in place like this for now. Right now it will show the button, but when clicked it should show an empty menu with the message "Coming soon. Check back later.". Adding
#mode=testto the URL and refreshing will show the different menu items. It's currently not completely functional which is why it's disabled by default, but this will allow me to test CORS from the real domain. Once I verify what needs to be done with CORS, I can make those changes and push subsequent updates to show the working install flows as I finish them.