Board Info Generator Script#1165
Merged
Merged
Conversation
Collaborator
Author
|
For some reason, the file is not actually uploading, so this is still being worked on. |
Collaborator
Author
|
I was getting a bit perplexed by this and then I realized it probably won't actually upload a file to Amazon S3 until after this has been merged for security reasons. So this should be good to go. |
dhalbert
requested changes
Mar 14, 2023
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Looks fine, but there is no newline at the end of generate-board-info.py. This is hard to fix from the GitHub web interface. Can you push a commit? Thanks.
Collaborator
Author
|
I just ran black so it would fix any other formatting issues. |
dhalbert
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of getting the CircuitPython Installer ready for learn, it's useful to have the necessary board info in a JSON file so that just the board id (or IDs) is all that will need to be provided. This PR adds a script to generate and upload the file to Amazon S3.
I plan on having these values overridable with the button parameters so that multiple languages can still be installed. After this is merged, changes to the installer to grab the info from this file will be required, which will be part of a follow-up PR.