Add M5Stack AtomS3 Lite#1183
Merged
Merged
Conversation
Collaborator
|
Yeah, bootloader_id and family should be all that are needed for the bootloader zip to show. |
makermelissa
approved these changes
Apr 11, 2023
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add the M5Stack AtomS3 Lite board
I have one question. In the board definition file I have added
bootloader_id: m5stack_atoms3_litewith the bootloader directory from adafruit/tinyuf2 repository.Is this enough for display the bootloader zip download?