Skip to content

Libraries and Contributing page#156

Merged
kattni merged 18 commits into
adafruit:masterfrom
jwcooper:libraries
Apr 27, 2019
Merged

Libraries and Contributing page#156
kattni merged 18 commits into
adafruit:masterfrom
jwcooper:libraries

Conversation

@jwcooper
Copy link
Copy Markdown
Member

Work in progress...

Comment thread libraries/index.html Outdated
Comment thread libraries/index.html Outdated
Copy link
Copy Markdown
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a few changes to the html pages.

Comment thread libraries/contributing.html Outdated
Comment thread libraries/contributing.html Outdated
Comment thread libraries/index.html Outdated
@jwcooper
Copy link
Copy Markdown
Member Author

jwcooper commented Apr 22, 2019

The last change needed based on feedback is the [x] count for the pull requests merged added to libraries.json

Copy link
Copy Markdown
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! Thank you for incorporating my updates! We're super close. We need to get the number of PRs added to the json file, and there are a couple of checks on the Library Infrastructure Issues list that need to be removed (sommersoft is on this).

I have one thing I meant to mention last time and failed to. See below.

Comment thread libraries/index.html Outdated
@jwcooper
Copy link
Copy Markdown
Member Author

@kattni, @sommersoft this is ready to go, if we're ready to merge the script. I think we could merge the script to master first, and then merge this in after.

Copy link
Copy Markdown
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! I really appreciate you sticking with me through it.

We can merge in whatever order you like, however the script won't do anything until we setup Travis. That's something that we will do.

@kattni
Copy link
Copy Markdown
Contributor

kattni commented Apr 27, 2019

Discussed with both @jwcooper and @sommersoft. This is ready to merge!

@kattni kattni merged commit 4e191ad into adafruit:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants