Skip to content

Support for XinaBox CC03 and CS11#325

Merged
makermelissa merged 29 commits into
adafruit:masterfrom
xinabox:master
Dec 19, 2019
Merged

Support for XinaBox CC03 and CS11#325
makermelissa merged 29 commits into
adafruit:masterfrom
xinabox:master

Conversation

@KalbeAbbas
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the circuitpython build naming first please

@KalbeAbbas
Copy link
Copy Markdown
Contributor Author

Ok. Thanks

@KalbeAbbas
Copy link
Copy Markdown
Contributor Author

We are closing the PR and will come back after some upgrades. Thanks

@KalbeAbbas KalbeAbbas closed this Nov 15, 2019
@KalbeAbbas KalbeAbbas reopened this Dec 16, 2019
Update fork with latest changes
Comment thread _board/CC03.md Outdated
Comment thread _board/CS11.md Outdated
Comment thread _board/CC03.md Outdated
Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the features need to be removed/changed. This is for search purposes and they need to be spelled the same or they come up as additional items in the list.

Some of your images are .png and some are .jpg, but under board image, you are using .jpg so some will not work. Please change them to be consistent. Also if you do go with .png, please add a background. Thanks.

Comment thread _board/xinabox_cc03.md Outdated
board_url: "https://drive.google.com/file/d/13xfg0SRZEeO-_xMElqdf0Sne8rjAcfyn/view"
board_image: "xinabox_cc03.jpg"
features:
- ARM Cortex-M0+ Architecture
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the guide page at https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads. On features, please only use the items in that list. If those are not features, either just leave it empty or remove the features block altogether. Thanks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @makermelissa, I've updated .mds and uploaded new images.

Comment thread _board/xinabox_cs11.md Outdated
Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. Looks good now.

@makermelissa makermelissa requested a review from ladyada December 19, 2019 16:48
@makermelissa makermelissa merged commit cc9ec10 into adafruit:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants