First pass at documentation for adding/changing hero images#402
Merged
Conversation
Per Phil. He stated that such documentation should be in markdown on circuitpython.org itself. In this PR, no accompanying images are used. If images are desired, we will need to determine where to put them. Under /assets or under /doc or somewhere else.
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 32.6%, saving 4.07 MB
Some images were already optimised
|
Contributor
Author
|
I didn't ask GitHub to do anything with the images, must be automatic..... |
Member
|
It is! And it's ok for this PR I think, it's simply optimizing the file sizes (the new heroes are much smaller). The issue I think is that normally it doesn't run properly as we push forked PR from our own repositories, so it suddenly has a bunch of images to optimize from previous pull requests. I'll look into that, as I'd like it to optimize images on each PR that comes in with new images. |
Contributor
Author
|
Added reviewers as PT stated he would look at it after merge in a basecamp message. |
kattni
suggested changes
Feb 5, 2020
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Looks good! One formatting note below.
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 78.8%, saving 601.10 KB
Some images were already optimised
|
Contributor
|
@TheKitty You'll need to deal with the merge conflicts but otherwise this is ready to merge when you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Phil. He stated that such documentation should be in markdown on circuitpython.org itself.
In this PR, no accompanying images are used. If images are desired, we will need to determine where to put them. Under /assets or under /doc or somewhere else.