Add Alorium Technology Evo M51#481
Merged
Merged
Conversation
makermelissa
requested changes
May 22, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
I just see one change to make, but looks good. Thanks.
| date_added: 2020-5-21 | ||
| downloads_display: true | ||
| blinka: false | ||
| download_instructions: "BLINKA ONLY - url" |
Collaborator
There was a problem hiding this comment.
Can we remove this line? It looks like you used the template and for non-Blinka boards it should be removed. Thanks
Contributor
Author
There was a problem hiding this comment.
Yes. I wasn't sure what to do with that line, so I left it in. So, no problem removing it.
Is that something I do?
Collaborator
There was a problem hiding this comment.
Yeah, just remove it and push the change.
makermelissa
approved these changes
May 22, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks great! Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.