Skip to content

fix files.json trailing commas#655

Merged
jepler merged 1 commit into
adafruit:masterfrom
Neradoc:fix-languages-list
Mar 24, 2021
Merged

fix files.json trailing commas#655
jepler merged 1 commit into
adafruit:masterfrom
Neradoc:fix-languages-list

Conversation

@Neradoc
Copy link
Copy Markdown
Contributor

@Neradoc Neradoc commented Mar 24, 2021

Fixes error on json.load().

Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Since this file is auto-generated, is this likely to be an issue in the future?

Copy link
Copy Markdown
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked and the changes look okay

@jepler jepler merged commit 499b1d7 into adafruit:master Mar 24, 2021
@dhalbert
Copy link
Copy Markdown
Collaborator

Thanks for fixing this. Since this file is auto-generated, is this likely to be an issue in the future?

This was my fault. It doesn't normally contain trailing commas. I had to edit it by hand due to adafruit/circuitpython#4470

Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Neradoc Neradoc deleted the fix-languages-list branch May 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants