Skip to content

_board/bdmicro_vina_d51.md (and images): Updates for latest revision.#689

Merged
makermelissa merged 2 commits into
adafruit:masterfrom
bd34n:bdmicro_vina_d51_update
May 11, 2021
Merged

_board/bdmicro_vina_d51.md (and images): Updates for latest revision.#689
makermelissa merged 2 commits into
adafruit:masterfrom
bd34n:bdmicro_vina_d51_update

Conversation

@bd34n
Copy link
Copy Markdown
Contributor

@bd34n bd34n commented May 10, 2021

Update images to the latest board revision and also update the description and product URLs. Capitalize the name.

Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the image sizes so they are a 10:13 ratio?
See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images

Also, please keep the features list limited to the items on this page:
https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-blinka. That's used to create the search filters.

You can just move them down to the description area if you'd like.
Thanks

@bd34n
Copy link
Copy Markdown
Contributor Author

bd34n commented May 11, 2021

Thanks, @makermelissa ! I totally missed the purpose of the features list, my apologies. And I have changed the image ratios to 13:1 as indicated on the link you provided. Originally, I only saw the 700x, 300x, and original size references. They weren't far off from 13:1, and now they should match exactly with a tiny bit of cropping.

Thanks again!

Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes.

@makermelissa makermelissa merged commit fc99f43 into adafruit:master May 11, 2021
@bd34n bd34n deleted the bdmicro_vina_d51_update branch May 11, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants