Added NanoESP32 S2 w/WROVER & reword WROOM version#703
Merged
Conversation
Collaborator
|
We'll need to update the _data/files.json to update the board names (https://github.com/adafruit/circuitpython-org/blob/master/_data/files.json#L14864-L14944) or we will have an Unknown Board appear for the old name. I see they are already updated in circuitpython itself, so that shouldn't really be an issue. |
makermelissa
approved these changes
Jun 2, 2021
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Ok, approving because this looks good. I'll submit a follow-up PR to fix the resulting unknown board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the download page for the new CircuitPython build for the Muse lab NanoESP32-S2 w/WROVER.
This pull request also update the download page of the original NanoESP32-S2 that is now named NanoESP32-S2 w/WROOM.
For reference, the related PR in CircuitPython repo: adafruit/circuitpython#4834