Lolin S2 Mini - added more specs useful for makers#754
Merged
Conversation
makermelissa
approved these changes
Sep 9, 2021
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-priority.
I'm happy to templatize this and other MCUs, modules, other components, etc., for consistency on board pages, and for anything that might be useful in the "Downloads" search field.
For search perhaps by using the same mechanism as, e.g.,
data-id="feather_nrf52840_express"...data-features="Feather-Compatible,Battery Charging,Bluetooth/BTLE,Breadboard-Friendly"and adding adata-mcuordata-componentsfield to include things likenrf52840orESP32-S2FN4R2, and/or other components, particularly useful for searching when MCU/component names do not appear indata-namenor elsewhere.