Add TTGO T8 ESP32-S2#886
Merged
Merged
Conversation
makermelissa
requested changes
Mar 8, 2022
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Could you add a bit of whitespace around the board images. Here's a guide with some information about the image sizes we're looking for:
https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images
fabaff
force-pushed
the
lilygo-ttgo-esp32-s2-nodisplay
branch
from
90ef58c to
ca07eed
Compare
fabaff
force-pushed
the
lilygo-ttgo-esp32-s2-nodisplay
branch
from
ca07eed to
1ce6a8d
Compare
Contributor
Author
Images are now replaced by "actual" images. |
makermelissa
approved these changes
Mar 9, 2022
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks great. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on adafruit/circuitpython#6079