Add missing atmel-samd and nrf52840 bootloader IDs #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
May 5, 2022
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Looks good! Caught one thing below.
| downloads_display: false | ||
| date_added: 2020-09-1 | ||
| family: atmel-samd | ||
| bootloader_id: ndbit7 |
Contributor
There was a problem hiding this comment.
Is this supposed to be ndbit6?
Collaborator
Author
There was a problem hiding this comment.
I don't believe so. There was already an ndbit6 board (different than this) and there is nothing called ndbit7, so I figured they were being clever.
kattni
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943.