Add missing espressif bootloader IDs #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neradoc
requested changes
May 6, 2022
Contributor
Neradoc
left a comment
Neradoc
left a comment
There was a problem hiding this comment.
Thanks !
One point in bootloaders.json, and I think the QT PY ESP32C3 needs its bootloader_id removed too.
https://github.com/adafruit/circuitpython-org/edit/main/_board/adafruit_qtpy_esp32c3.md
Co-authored-by: Neradoc <Neradoc@users.noreply.github.com>
Collaborator
Author
|
Updated. Anything else? |
Neradoc
previously approved these changes
May 10, 2022
Contributor
Neradoc
left a comment
Neradoc
left a comment
There was a problem hiding this comment.
Seems all good to me. The hiibot iots2 has been added to the tinyuf2 CI, but it won't be available until the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943. Pulled IDs from here: https://github.com/adafruit/tinyuf2/releases. Some were missing. A couple C3 bootloader IDs removed due to not using native USB.