Skip to content

Contribute section seems automatic...#962

Merged
dhalbert merged 3 commits into
adafruit:mainfrom
dglaude:patch-6
May 24, 2022
Merged

Contribute section seems automatic...#962
dhalbert merged 3 commits into
adafruit:mainfrom
dglaude:patch-6

Conversation

@dglaude
Copy link
Copy Markdown
Contributor

@dglaude dglaude commented May 24, 2022

The automatic version goes to main where the manual version was going to master
So it appear duplicate in https://circuitpython.org/board/mixgo_ce_serial/

Maybe it is not clearly documented that this section is not to be submitted manually?

dglaude and others added 3 commits May 24, 2022 13:33
The automatic version goes to `main` where the manual version was going to `master`
So it appear duplicate in https://circuitpython.org/board/mixgo_ce_serial/
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this! If you have a suggestion for the README about the auto-"Contribute" section", a PR there would be welcome as well.

@dhalbert dhalbert merged commit 66fdd0d into adafruit:main May 24, 2022
@dglaude dglaude deleted the patch-6 branch May 25, 2022 12:23
@dglaude
Copy link
Copy Markdown
Contributor Author

dglaude commented May 25, 2022

I did not check the documentation, but I checked 20+ of the latest new board, and only two had that duplicate, and from the same author. So I guess the instruction are OK and the same mistake was done twice by the same author.
Maybe the "Contribute" section could be put elsewhere, more global to the page and not in the same text box, so that what appear in the box is exactly and only what was provided in the md file for this board.

@makermelissa makermelissa mentioned this pull request May 25, 2022
6 tasks
@makermelissa
Copy link
Copy Markdown
Collaborator

I saw it was in https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads (pointing to master) and just removed it. So that was likely the culprit.

@dahanzimin
Copy link
Copy Markdown
Contributor

Thanks for helping to correct some errors. When can I download mixgo_ce firmware from the circuitpython-org

@makermelissa
Copy link
Copy Markdown
Collaborator

The button should appear in the next release of CircuitPython, but you can click the Browse S3 button now to see all builds which include any that happen when a Pull Request gets merged.

@makermelissa
Copy link
Copy Markdown
Collaborator

#965 will automatically check for this from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants