Add driver for TSL2561 Light Sensor

[caternuson]

Add driver to support the Adafruit TSL2561 Digital Luminosity/Lux/Light Sensor Breakout.

• PID 439

[tannewt]

There is an older MicroPython version you can start from here: https://github.com/adafruit/micropython-adafruit-tsl2561

I believe @KurticusMaximus was also looking to cookiecutterify a similar repo.

[caternuson]

In-work version lives here:
https://github.com/caternuson/CircuitPython_TSL2561

[tannewt]

Hey, here is some feedback. I can't comment easily inline. So here it is:

• How about renaming lux to light to match the doc here, which has its roots in teh unified arduino driver spec. https://circuitpython.readthedocs.io/en/1.x/docs/design_guide.html#sensor-properties-and-units
• Nitpick:

        if self._read_register(TSL2561_REGISTER_CONTROL) & 0x03:
            return True
        else:
return False

is

        return self._read_register(TSL2561_REGISTER_CONTROL) & 0x03

• Another nitpick is the (self, ) should be (self).

Overall the API looks good to me! I ❤️ properties.

[caternuson]

• fine by me. will do.
• indeed. you're better at this than i am. :) (i'm going to cast to bool though)
• yah, i like doing no arg functions that way for some reason. easy to not do it though.

[tannewt]

Ok, I've forked this into Adafruit and set up ReadTheDocs. Mind creating a PR to get this in the bundle and fixing the docs?

It looks like the API docs aren't building quite right because of const. https://readthedocs.org/projects/adafruit-circuitpython-tsl2561/builds/6166595/ Try adding from micropython import const to the top and using ReadTheDocs to automock the micropython module. (Other drivers do this already.

[caternuson]

PR done: adafruit/Adafruit_CircuitPython_Bundle#32

Where do I add that import?

[caternuson]

Hmmmm. Maybe back to lux instead of light?
c966976

[tannewt]

Yes please. :-) Limor just tweaked it.

…

On Thu, Oct 26, 2017 at 9:11 AM Carter Nelson ***@***.***> wrote: Hmmmm. Maybe back to lux instead of light? c966976 <c966976> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#314 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADNqesV6jjdYZBxtW_NqJBY-oWgdfVMks5swK8pgaJpZM4P0w33> .

[caternuson]

Try adding from micropython import const to the top

this goes in conf.py?

[tannewt]

That goes in the driver and the autodoc_mock statement goes in conf.py.