nrf: Rewrite the DigitalInOut hal using nRFx#1002
Merged
Merged
Conversation
dhalbert
reviewed
Jul 10, 2018
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
These are followup comments to an already approved PR.
| if (self->open_drain) { | ||
| digitalio_digitalinout_obj_t *self) { | ||
| if (self->open_drain) | ||
| return DRIVE_MODE_OPEN_DRAIN; |
| // True is implemented differently between modes so reset the value to make | ||
| // sure its correct for the new mode. | ||
| if (value) { | ||
| if (value) |
Collaborator
There was a problem hiding this comment.
I know this is already approved, but I would ask you not to remove braces around single statements in control structures. Please always use braces in control structures, except perhaps in the most extreme cases (like very stylized single-line code). I've had to fix several bugs over the years that were caused by edits to code with missing braces.
Collaborator
Author
There was a problem hiding this comment.
Sorry, I'll try to remember, at this point it's muscle memory 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.