Skip to content

do not call property if referenced by class, not object#1028

Merged
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:class-property-fix
Jul 16, 2018
Merged

do not call property if referenced by class, not object#1028
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:class-property-fix

Conversation

@dhalbert
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert commented Jul 15, 2018

Fixes #1027.

>>> import analogio
>>> analogio.AnalogIn.value   # this used to hang or (in 2.x) return an integer
<property>
>>> import board
>>> a0 = analogio.AnalogIn(board.A0)
>>> a0.value
27200

I should probably submit this upstream as well. (I thought this code was in upstream but it is not.)

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 6c5a152 into adafruit:master Jul 16, 2018
@dhalbert dhalbert deleted the class-property-fix branch August 6, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants