Open
Conversation
dhalbert
requested changes
Feb 16, 2026
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks - this seems convenient. I often end up editing an mpconfigboard.mk temporarily, but this is less intrusive.
Author
|
I changed the filenames as you suggested. |
dhalbert
approved these changes
Feb 16, 2026
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks. I hope you think the new names clarify things.
Collaborator
|
@tannewt Do you have any suggestions? If not I'll merge. |
Author
Yes they do, thanks for the suggestions. |
tannewt
requested changes
Feb 17, 2026
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This looks fine to me. The one suggestion I have is to document this somewhere so others can use it. Maybe somewhere in docs/?
Author
|
What about adding a section in |
Member
Works for me! Thanks! |
mimi89999
pushed a commit
to mimi89999/circuitpython
that referenced
this pull request
Feb 17, 2026
This reduces inconsitencies between esp32 and other ports. According to the discussion in adafruit#10817. Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for user-specific makefile-includes.
Currently, there are mainly
mpconfigboard.mk(board-specific)mpconfigport.mk(port-specific)circuitpy_mpconfig.mk(globals)User-overrides are possible from the
makecommandline (except for a number of hardcoded settings), but this gets tedious. This patch allows power-users to put the changes in user-specific files with the added benefit that you can use makefile-logic to limit the changes to specific ports or boards.User configuration can be maintained out-of-tree, e.g.
will build with two different sets of user-configurations.
User configurations are optional, they are included via
-include, so a missing include file does not even generate a warning.