Merged
Conversation
Member
tannewt
commented
Mar 30, 2026
tannewt
commented
- Fix flash writing with more than 32 filesystem blocks per erase page and add a test for it.
- Fix Feather UF2 to place code in the right spot (the code partition).
1. Fix flash writing with more than 32 filesystem blocks per erase page and add a test for it. 2. Fix Feather UF2 to place code in the right spot (the code partition).
dhalbert
approved these changes
Apr 1, 2026
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Nice generalizations in the cache flashing. I guess if everything is zephyr this would not need to be back-ported to other ports' flash implementations, but would it make sense to factor it out as port-independent, or is there too much zephyr-only stuff there (I'm not sure, but it looks like not).
Member
Author
|
I don't think we need to factor it out because my hope is to migrate everything to Zephyr eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.