enable msgpack in zephyr port and add test for it. fix unpack issue#10927
Merged
tannewt merged 1 commit intoadafruit:mainfrom Apr 8, 2026
Merged
enable msgpack in zephyr port and add test for it. fix unpack issue#10927tannewt merged 1 commit intoadafruit:mainfrom
tannewt merged 1 commit intoadafruit:mainfrom
Conversation
…ue in msgpack unpack.
Member
I usually run
Whoa! I did not know that. Python does left-to-right: https://docs.python.org/3/reference/expressions.html#evaluation-order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled
msgpackcore module in the zephyr port and addedtest_msgpack.pyto validate its functionality. I'm wondering if there is something else I need to do to get the rest of the autogen files to update? The only ones committed in this branch are the two devices that I built.The test was initially failing when run on the native sim but passing when run on hardware. Claude assisted debug points to the issue being that the calls like
mp_obj_dict_store(d, unpack(s, ext_hook, use_list), unpack(s, ext_hook, use_list));do not guarantee the evaluation order of function arguments. So the compiler could evaluate them in the unintended order which was leading to dictionaries coming out as {value: key} instead of {key: value}. The fix is to split that statement up and call unpack in the intended order explicitly.