Support internationalisation.#1097
Merged
Merged
Conversation
dhalbert
reviewed
Aug 8, 2018
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Did you mean to check in the locale/circuitpython.pot? It looks like it's generated in the Makefile.
How are the .po files generated? How and when should they be updated? What updates the filenames and line numbers?
Maybe give a pointer to doc if it's already explained elsewhere.
Collaborator
|
OK, I see: I read this: https://www.icanlocalize.com/site/tutorials/how-to-translate-with-gettext-po-and-pot-files/ |
dhalbert
approved these changes
Aug 8, 2018
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Having translations will be great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add a string in the code to the list of translations
#include "supervisor/shared/translate.h", wrap it intranslate(), and runmake translate.To build with a specific translation provide
TRANSLATIONto make. For example:make -j3 BOARD=trinket_m0 TRANSLATION=esTo start a new translation copy
locale/circuitpython.pottolocale/<language code>.powhere<language code>is an IETF language tag with underscores between subtags.Filenames will now include language tag after board but before version. For example:
adafruit-circuitpython-itsybitsy_m4_express-es-20180803-230171a9d.bin