adapt #10899 to main#10989
Open
dhalbert wants to merge 1 commit intoadafruit:mainfrom
Open
Conversation
tannewt
requested changes
May 8, 2026
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One comment that should be removed.
Comment on lines
+21
to
+25
| //| .. note:: | ||
| //| Programs that call ``microcontroller.reset()`` should wait at least | ||
| //| one second after boot before resetting, otherwise CircuitPython's | ||
| //| double-reset safe mode detector may activate. See | ||
| //| ``supervisor/shared/safe_mode.c``. |
Member
There was a problem hiding this comment.
I don't think this is true because the safe mode wait happens before user code is run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts #10899, which was against
10.1.x, tomain.Since #10899, there was conditional compilation code added for Espressif chips without RTC memory. (I don't see that there actually are any such chips.) This PR merges #10899, and incorporates that new
#ifcheck.FYI @lzrd