Remove Nrf52 bootloader target and hex#1099
Conversation
- rename linker file, update boot - update bootloader path - keep nrf52832 as it is
|
I don't think we should add any knowledge of the bootloader to CircuitPython. It's only used to provide convenience targets in the Makefile to flash the bootloader. Those targets should be removed. The documentation and Makefile in it's own repo is enough. |
tannewt
left a comment
There was a problem hiding this comment.
This shouldn't be merged. The bootloader targets in the Makefile should be removed instead.
|
@tannewt the bootloader target in the makefile is to flash the bootloader on the device with jlink, or you are referring to other targets. Could you say the target name specifically. |
|
Hmm, probably it is a bit confusing, I will update the readme a bit. |
|
update: the readme does mentions dfu-flash and dfu-flash already, @tannewt would you mind telling which lines of the makefile you want to remove. |
|
I think @tannewt is saying to not have anything about the bootloader in the We don't have targets that load the UF2 bootloader in the |
|
@dhalbert maybe we should remove bootloader as the submodule as well, just tell people to clone the bootloader and flash it there in the readme.md |
|
close this one by now, I need to do a few more things with bootloader repo and submit a separate PR. |
To prevent adding hex file each time we modify bootloader. Bootloader comes with pre-builtin hex for S140 6.1.0 and S132 6.1.0 for feather & pca10056.Bootloader related targets and hex are removed, user need to clone the bootloader repo should they need to flash or upgrade board's bootloader.- bootloader does also include nrfx and tinyusb, kind of duplication. But it is also standalone, have no idea to go around this.