restore ESPNow to some functionality#11075
Merged
Merged
Conversation
dhalbert
force-pushed
the
restore-espnow-functionality
branch
from
68dcf5f to
a1e9594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESPNow was broken on ESP32-S3 as of the ESP-IDF v6.0.1 upgrade, and was failing on other boards earlier.
This restores it to working at least to some extent.
The new way to set the
phy_rateis withesp_now_set_peer_rate_config(). However, this function is poorly documented (I opened espressif/esp-idf#18766), and the settings for the passed struct are not documented.To fix this for now, I just commented out the ability to set the
phy_rate, leaving it at the default 1Mbps. I added documentation to point out setting thephy_ratedoes nothing for now.Also note that
esp_now_set_peer_rate_config()should be called afteresp_now_init(). It was being called before.I tested with an ESP32-S3 broadcasting and and ESP32-C6 receiving, using the example code in https://learn.adafruit.com/esp-now-in-circuitpython/code-esp-now.
@todbot for interest.