Capacitance#136
Conversation
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks pretty good! It still has the metro pin name changes in it though. You'll need to drop the first commit by running git rebase -i and deleting the line that commit is on and then force pushing (git push --force) the branch. This should preserve the second commit while deleting the first. (The other branch for the pull request for it will still have the first commit.)
There was a problem hiding this comment.
Please remove this whitespace change and the extra lines above.
There was a problem hiding this comment.
Please move this comment above the touchio_touchin_obj_get_capacitance method to match how value is done.
Also, simplify the comment to "The raw capacitance measurement." without mentioning the SAMD21 because it will be provided by all ports that support touch.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Only one empty line here please.
|
Thanks for removing the extra commits. There are some other comments that need to be addressed before pulling it in. |
|
Closing this for now, but happy to add it when you need it. |
3 participants
This adds the get capacitance value to the touchio library , so users can use the raw measurements to for anything else they want.