Xplain#137
Closed
robomike wants to merge 1 commit into
Closed
Conversation
tannewt
requested changes
May 22, 2017
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This looks good except for the fact that it inadvertantly includes the touchio and metro pin changes in it. Similar to the touchio pull, you'll need to git rebase -i, delete the lines for the commits you don't want on this branch (and pull request) and then force push the changes to the pull (git push --force). The two commits you delete from this branch will still exist on your other two branches.
Member
|
Please use git rebase to change the commit message to something like "atmel-samd: Add support for the SAMD21 Xplained board." Everything else looks good. |
Collaborator
|
Closing this for now; let us know if you still need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the SAMD21Xplained PRO board to the Circuit Python development library