Nrf52 esp83266 uart bug#1428
Merged
Merged
Conversation
jerryneedell
approved these changes
Dec 27, 2018
Collaborator
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
I have run this PR on both the particle_xenon and particle_argon allowiing hard resets of the ESP8266 on the xenon and the ESP32 on the argon -- both worked normally after the resets -- this appears to fix the issue.
I also verified on the particle xenon that pressing the RESET button on the ESP8266 did not cause it tho hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1407
root cause is the frame error, stop bit is not valid (not data overflow as suspected), data is literally garbage. Solution is just ignore the garbage data and keep receiving.