Add USB MIDI support for SAMD and nRF.#1449
Merged
Merged
Conversation
The API should be identical to using a UART for MIDI. Fixes micropython#672
dhalbert
requested changes
Jan 9, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Very clean! Looks great! A few comments, maybe no substantive changes necessary.
|
Huzzah! 🎹 |
Collaborator
|
Travis failure is nRF52832 which is going away anyway. |
Member
Author
|
@dhalbert This is ready for another look when you have a chance. |
dhalbert
approved these changes
Jan 11, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Great! Another huge addition to our functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API should be identical to using a UART for MIDI.
Fixes #672