Add displayio.Shape#1472
Merged
Merged
Conversation
Also, swap make_news to accept a kwarg map and refine param checking. Fixes micropython#1237
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
displayio.Shape is a subclassable class that stores shapes by storing boundaries of the shape for each row of pixels. It also allows for mirroring to save memory.
Most of the changes are to enable subclassing native classes which take keyword args. To do so, the signature of make_new changed to take a separate kw_arg map. The basic argument checking changed as a result as well.
FourWire and Group now handle accepting subclasses as well by calling
mp_instance_cast_to_native_baseto get the native root object.