Rework displays#1476
Merged
Merged
Conversation
Fixes micropython#1465. Fixes micropython#1337. Fixes micropython#1168
|
👍 👍 👍 📺 |
dhalbert
requested changes
Jan 18, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Lotsa comments but looks great! Thanks for cleaning up FourWire to use standard SPI, and great job refactoring to shared code!
Member
Author
|
Ok, please take another look. |
dhalbert
requested changes
Jan 19, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Just the one width/height thing.
Member
Author
|
@dhalbert Build is green now. |
dhalbert
approved these changes
Jan 21, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Travis bingo!
| ------ | ------ | ------ | ------ | ------ |
|---|---|---|---|---|
| ❌ 2426.1 | ❌ 2426.2 | ❌ 2426.3 | ❌ 2426.4 | ❌ 2426.5 |
| - | - | - | - | - |
| - | - | FREE | - | - |
| - | - | - | - | - |
| ------ | ------ | ------ | ------ | ------ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes displays much more accessible by allowing them to be dynamically created. They have unusual lifetimes because they live through reloads so they can display error messages. To release them you must call
displayio.release_displays().This PR also splits the display bus mechanics from the display commands and adds 8 bit parallel bus support for faster pixel transmission.