bleio: handle events sent by newer devices and by Android#1491
Merged
Conversation
Collaborator
Author
|
Pushed another commit, which handles the additional event BLE_GATTS_EVT_SYS_ATTR_MISSING, used by Android devices. Tested by @jerryneedell on Android, fixes those too. |
dhalbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer BLE devices may ask to lengthen the basic BLE packet size. This request was not being handled, and so the connection attempt from a central to CircuitPython Peripheral was hanging. Respond in the correct way to this request.
@jerryneedell This I believe will fix adafruit/Adafruit_CircuitPython_BLE#2. I tested on a 2018 iPad. Didn't test on an Android device, but thanks for testing if you are able to do so.
iPhone 6s and lower did not send this request. iPhone 7 (and probably up) do.