Skip to content

fix kw_arg checking for time.struct_time()#1497

Merged
tannewt merged 1 commit into
adafruit:masterfrom
jerryneedell:jerryn_fix_time
Jan 25, 2019
Merged

fix kw_arg checking for time.struct_time()#1497
tannewt merged 1 commit into
adafruit:masterfrom
jerryneedell:jerryn_fix_time

Conversation

@jerryneedell
Copy link
Copy Markdown
Collaborator

fixes #1493 -- change suggested by @tannewt
tested on metro_m4_express and itsybitsym4_express

@jerryneedell jerryneedell requested a review from tannewt January 25, 2019 20:00
@jerryneedell
Copy link
Copy Markdown
Collaborator Author

jerryneedell commented Jan 25, 2019

I just submitted thia PR -- but it does not appear to have kicked off Travis build -- did I do something wrong?

It is running on travis-ci.org --- not sure why or if that matters. will let it finish there and see what happens

@jerryneedell
Copy link
Copy Markdown
Collaborator Author

jerryneedell commented Jan 25, 2019

travis ran on travis-ci.org and passed, but I don't know how to get it to migrate my fork to travis-ci.com? https://travis-ci.org/jerryneedell/circuitpython/builds/484520162?utm_medium=notification&utm_source=email

@dhalbert
Copy link
Copy Markdown
Collaborator

Hi, we enrolled in the Travis beta migration program: https://docs.travis-ci.com/user/migrate/open-source-on-travis-ci-com/#existing-open-source-repositories-on-travis-ciorg. Once we were in it, a list of repos we could migrate showed up on https://travis-ci.org/account/repositories at the bottom, if I remember right, with "Migrate" buttons. You can also just wait for them to migrate your repo eventually.

@dhalbert
Copy link
Copy Markdown
Collaborator

The PR should have triggered a build, though; we're not sure why it didn't happen. Neither Travis nor GitHub are reporting problems currently.

@jerryneedell
Copy link
Copy Markdown
Collaborator Author

So-any idea how to proceed?

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Jan 25, 2019

I think its low risk so I'll approve and merge.

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tannewt tannewt merged commit cd0aacc into adafruit:master Jan 25, 2019
@jerryneedell jerryneedell deleted the jerryn_fix_time branch January 25, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

call to time.struct_time() fails in beta-0

3 participants