Add option to disable the concurrent write protection#1584
Merged
dhalbert merged 3 commits intoFeb 21, 2019
Conversation
This allows writing to the filesystem from the host computer and CircuitPython by increasing the risk of filesystem corruption.
dhalbert
requested changes
Feb 21, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Unix coverage build is failing with:
build-coverage/extmod/vfs_fat_file.o: In function `file_open':
vfs_fat_file.c:(.text+0x6fd): undefined reference to `filesystem_is_writable_by_python'
collect2: error: ld returned 1 exit status
| //| | ||
|
|
||
| //| .. function:: mount(filesystem, mount_path, \*, readonly=False) | ||
| //| .. function:: mount(filesystem, mount_path, \*, readonly=False, disable_concurrent_write_protection=False) |
Collaborator
There was a problem hiding this comment.
disable_concurrent_write_protection is listed as a new arg here for mount(), but it's not implemented. Did you mean to add it as with remount(), or is this a typo?
Member
Author
There was a problem hiding this comment.
Yup, a bug. I thought I had fixed that but probably forgot to save.
dhalbert
approved these changes
Feb 21, 2019
|
Was there a reason for this? The FS is managed by USB_MSC and thus should not be able to get corrupted. update: probably "yes" is the answer: https://forums.adafruit.com/viewtopic.php?p=1020232#p1020232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows writing to the filesystem from the host computer and
CircuitPython by increasing the risk of filesystem corruption.