Fix crash when getting board.SPI outside the VM#1756
Fix crash when getting board.SPI outside the VM#1756dhalbert merged 7 commits intoadafruit:masterfrom
Conversation
If one of the default pins was already in use it would crash. The internal API has been refined to allow us to get the value without causing an init of the singleton. Fixes micropython#1753
|
tested and it worked on my cpx! |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I get the idea, but some overall comments would help to explain the non-VM lifetime of the spi object.
Some nrf builds are failing, as is gemma (though not trinket) and pirkey.
|
Ok, I've refactored everything so it touches many more files. Hopefully it all makes more sense. I did add a |
That's a great idea! |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Just a stale comment to remove. Looks great!
|
Bunch of builds failing :( |
It is about 5kb and the pins aren't broken out for it anyway.
USB MIDI was still being compiled in mostly anyway. There is no place to touch on the board so touchio is useless.
|
Ok, I think this next run should pass. I fixed boards without shared busses, removed |
3 participants
If one of the default pins was already in use it would crash.
The internal API has been refined to allow us to get the value
without causing an init of the singleton.
Fixes #1753